.gitlab-ci.yml

@@ -16,7 +16,7 @@ build:
   stage: build
   script:
     - "platformio run -e esp12e"
-    - vers=$(grep -Po '[0-9]+\.[0-9]+\.[0-9]+[-0-9A-Za-z]*(?=\")' ./src/Pins.h)
+    - vers=$(grep -Po '[0-9]*\.[0-9]*\.[0-9]*(?=\")' ./src/Pins.h)
     - mv .pio/build/esp12e/*.bin Pumpensteuerung-${vers}.bin
   artifacts:
     paths:

factory_settings.ini

@@ -13,7 +13,6 @@ build_flags =
     -D FACTORY_AP_LOCAL_IP=\"192.168.4.1\"
     -D FACTORY_AP_GATEWAY_IP=\"192.168.4.1\"
     -D FACTORY_AP_SUBNET_MASK=\"255.255.255.0\"
-    -D FACTORY_AP_VISIBLE=true
 
     ; User credentials for admin and guest user
     -D FACTORY_ADMIN_USERNAME=\"admin\"

interface/src/ap/APSettingsForm.tsx

@@ -3,9 +3,8 @@ import { TextValidator, ValidatorForm, SelectValidator } from 'react-material-ui
 
 import MenuItem from '@material-ui/core/MenuItem';
 import SaveIcon from '@material-ui/icons/Save';
-import Checkbox from '@material-ui/core/Checkbox';
 
-import {PasswordValidator, RestFormProps, FormActions, FormButton, BlockFormControlLabel} from '../components';
+import { PasswordValidator, RestFormProps, FormActions, FormButton } from '../components';
 
 import { isAPEnabled } from './APModes';
 import { APSettings, APProvisionMode } from './types';
@@ -92,16 +91,6 @@ class APSettingsForm extends React.Component<APSettingsFormProps> {
               onChange={handleValueChange('subnet_mask')}
               margin="normal"
             />
-              <BlockFormControlLabel
-                  control={
-                      <Checkbox
-                          value="network_visible"
-                          checked={data.network_visible}
-                          onChange={handleValueChange("network_visible")}
-                      />
-                  }
-                  label="Network visible?"
-              />
           </Fragment>
         }
         <FormActions>

interface/src/ap/types.ts

@@ -24,5 +24,4 @@ export interface APSettings {
   local_ip: string;
   gateway_ip: string;
   subnet_mask: string;
-  network_visible: boolean;
 }

interface/src/project/GeneralInformation.tsx

@@ -4,7 +4,6 @@ import {FormButton, restController, RestControllerProps, RestFormLoader, Section
 import {ENDPOINT_ROOT} from "../api";
 import {GeneralInformaitonState} from "./types";
 import RefreshIcon from "@material-ui/icons/Refresh";
-import {getRealTimeString, stringifyTime} from "./Time";
 
 // define api endpoint
 export const GENERALINFORMATION_SETTINGS_ENDPOINT = ENDPOINT_ROOT + "generalinfo";
@@ -12,10 +11,16 @@ export const GENERALINFORMATION_SETTINGS_ENDPOINT = ENDPOINT_ROOT + "generalinfo
 type GeneralInformationRestControllerProps = RestControllerProps<GeneralInformaitonState>;
 
 class GeneralInformation extends Component<GeneralInformationRestControllerProps> {
+    intervalhandler: number | undefined;
+
     componentDidMount() {
         this.props.loadData();
     }
 
+    componentWillUnmount() {
+        clearInterval(this.intervalhandler);
+    }
+
     render() {
         return (
             <SectionContent title='Information' titleGutter>
@@ -27,40 +32,35 @@ class GeneralInformation extends Component<GeneralInformationRestControllerProps
                                 <ListItem>
                                     <ListItemText
                                         primary="Chip läuft seit:"
-                                        secondary={<>{stringifyTime(props.data.runtime)}
+                                        secondary={this.stringifyTime(props.data.runtime) + ' / ' + this.getRealTimeString(props.data.runtime)}
-                                            <br/> {getRealTimeString(props.data.runtime)}</>}
                                     />
                                 </ListItem>
                                 <ListItem>
                                     <ListItemText
                                         primary="Zuletzt zu wenig Wasser:"
-                                        secondary={props.data.lastWaterOutage !== 0 ?
+                                        secondary={props.data.lastWaterOutage !== 0 ? "vor " +
-                                            <>
+                                            this.stringifyTime(props.data.lastWaterOutage) + ' / ' +
-                                                vor {stringifyTime(props.data.lastWaterOutage)}<br/>
+                                            this.getRealTimeString(props.data.lastWaterOutage) : "noch nie!"}
-                                                {getRealTimeString(props.data.lastWaterOutage)}
-                                            </> : "noch nie!"}
                                     />
                                 </ListItem>
                                 <ListItem>
                                     <ListItemText
                                         primary="Letzer Pumpenzyklus"
-                                        secondary={props.data.lastpumptime !== 0 ?
+                                        secondary={props.data.lastpumptime !== 0 ? "vor " +
-                                            <>
+                                            this.stringifyTime(props.data.lastpumptime) + ' / ' +
-                                                vor {stringifyTime(props.data.lastpumptime)}<br/>
+                                            this.getRealTimeString(props.data.lastpumptime) : "noch nie!"}
-                                                {getRealTimeString(props.data.lastpumptime)}
-                                            </> : "noch nie!"}
                                     />
                                 </ListItem>
                                 <ListItem>
                                     <ListItemText
                                         primary="Letze Pumpdauer:"
-                                        secondary={props.data.lastPumpDuration !== 0 ? stringifyTime(props.data.lastPumpDuration) : "-"}
+                                        secondary={props.data.lastPumpDuration !== 0 ? this.stringifyTime(props.data.lastPumpDuration) : "-"}
                                     />
                                 </ListItem>
                                 <ListItem>
                                     <ListItemText
-                                        primary="Pumpzyklen seit Programmstart"
+                                        primary="Temperatur/Luftfeuchtigkeit:"
-                                        secondary={props.data.pumpcycles}
+                                        secondary={(props.data.temp !== -1 ? props.data.temp + "C" : "Auslesefehler!") + " / " + (props.data.hum !== -1 ? props.data.hum + "%" : "Auslesefehler!")}
                                     />
                                 </ListItem>
                                 <ListItem>
@@ -87,6 +87,40 @@ class GeneralInformation extends Component<GeneralInformationRestControllerProps
             </SectionContent>
         );
     }
+
+    /**
+     * stringify seconds to a pretty format
+     * @param sec number of seconds
+     */
+    private stringifyTime(sec: number): string {
+        if (sec >= 86400) {
+            // display days
+            return (Math.trunc(sec / 86400) + "d " + Math.trunc((sec % 86400) / 3600) + "h " + Math.trunc((sec % 3600) / 60) + "min " + sec % 60 + "sec");
+        } else if (sec >= 3600) {
+            // display hours
+            return (Math.trunc(sec / 3600) + "h " + Math.trunc((sec % 3600) / 60) + "min " + sec % 60 + "sec");
+        } else if (sec >= 60) {
+            // only seconds and minutes
+            return (Math.trunc(sec / 60) + "min " + sec % 60 + "sec");
+        } else {
+            // only seconds
+            return (sec + "sec");
+        }
+    }
+
+    private getRealTimeString(runtime: number): string {
+        const timestamp = Date.now();
+
+        const a = new Date(timestamp - (runtime * 1000));
+        const months = ['Jan','Feb','Mar','Apr','May','Jun','Jul','Aug','Sep','Oct','Nov','Dec'];
+        const year = a.getFullYear();
+        const month = months[a.getMonth()];
+        const date = a.getDate();
+        const hour = a.getHours();
+        const min = "0" + a.getMinutes();
+        const sec = "0" + a.getSeconds();
+        return '[' + date + ' ' + month + ' ' + year + ' ' + hour + ':' + min.substr(-2) + ':' + sec.substr(-2) + ']';
+    }
 }
 
 export default restController(GENERALINFORMATION_SETTINGS_ENDPOINT, GeneralInformation);

interface/src/project/HeatingInformation.tsx

@@ -1,70 +0,0 @@
-import React from "react";
-import {FormButton, restController, RestControllerProps, RestFormLoader, SectionContent} from "../components";
-import {ENDPOINT_ROOT} from "../api";
-import {Box, List, ListItem, ListItemText} from "@material-ui/core";
-import RefreshIcon from "@material-ui/icons/Refresh";
-import {getRealTimeString, stringifyTime} from "./Time";
-import {HeatingInformationState} from "./types";
-
-// define api endpoint
-export const HEATING_ENDPOINT = ENDPOINT_ROOT + "heatinginfo";
-
-type HeatingRestcontollerprops = RestControllerProps<HeatingInformationState>;
-
-class HeatingInformation extends React.Component<HeatingRestcontollerprops> {
-    componentDidMount() {
-        this.props.loadData();
-    }
-
-    render = () => (
-        <SectionContent title='Heizung Information' titleGutter>
-            <RestFormLoader
-                {...this.props}
-                render={props => (
-                    <>
-                        <List>
-                            <ListItem>
-                                <ListItemText
-                                    primary="Heizung lief zuletzt:"
-                                    secondary={props.data.lastheating !== 0 ?
-                                        <>
-                                            vor {stringifyTime(props.data.lastheating)}<br/>
-                                            {getRealTimeString(props.data.lastheating)}
-                                        </> : "noch nie!"}
-                                />
-                            </ListItem>
-                            <ListItem>
-                                <ListItemText
-                                    primary="Letze Heizdauer:"
-                                    secondary={props.data.lastheatduration === 0 ? "-" : props.data.lastheatduration === -1 ? "läuft gerade!" : stringifyTime(props.data.lastheatduration)}
-                                />
-                            </ListItem>
-                            <ListItem>
-                                <ListItemText
-                                    primary="Gesammte Heizdauer / Prozentuelle Einschaltzeit"
-                                    secondary={stringifyTime(props.data.totalheattime) + ' / ' + (props.data.heattimepercent * 100).toFixed(2) + '%'}
-                                />
-                            </ListItem>
-                            <ListItem>
-                                <ListItemText
-                                    primary="Temperatur/Luftfeuchtigkeit:"
-                                    secondary={(props.data.temp !== -1 ? props.data.temp + "C" : "Auslesefehler!") + " / " + (props.data.hum !== -1 ? props.data.hum + "%" : "Auslesefehler!")}
-                                />
-                            </ListItem>
-                        </List>
-                        <Box display="flex" flexWrap="wrap">
-                            <Box flexGrow={1} padding={1}>
-                                <FormButton startIcon={<RefreshIcon/>} variant="contained" color="secondary"
-                                            onClick={this.props.loadData}>
-                                    Refresh
-                                </FormButton>
-                            </Box>
-                        </Box>
-                    </>
-                )}
-            />
-        </SectionContent>
-    );
-}
-
-export default restController(HEATING_ENDPOINT, HeatingInformation);

interface/src/project/PumpControl.tsx

@@ -9,7 +9,6 @@ import { AuthenticatedRoute } from '../authentication';
 
 import GeneralInformation from './GeneralInformation';
 import SettingsController from "./SettingsController";
-import HeatingInformation from "./HeatingInformation";
 
 class PumpControl extends Component<RouteComponentProps> {
 
@@ -22,12 +21,10 @@ class PumpControl extends Component<RouteComponentProps> {
       <MenuAppBar sectionTitle="Wasserpumpensteuerung">
         <Tabs value={this.props.match.url} onChange={this.handleTabChange} variant="fullWidth">
           <Tab value={`/${PROJECT_PATH}/pumpe/information`} label="Information" />
-            <Tab value={`/${PROJECT_PATH}/pumpe/heizung`} label="Heizung" />
           <Tab value={`/${PROJECT_PATH}/pumpe/settings`} label="Einstellungen" />
         </Tabs>
         <Switch>
           <AuthenticatedRoute exact path={`/${PROJECT_PATH}/pumpe/information`} component={GeneralInformation} />
-            <AuthenticatedRoute exact path={`/${PROJECT_PATH}/pumpe/heizung`} component={HeatingInformation} />
           <AuthenticatedRoute exact path={`/${PROJECT_PATH}/pumpe/settings`} component={SettingsController} />
           <Redirect to={`/${PROJECT_PATH}/pumpe/information`} />
         </Switch>

interface/src/project/Time.ts

@@ -1,33 +0,0 @@
-/**
- * stringify seconds to a pretty format
- * @param sec number of seconds
- */
-export function stringifyTime(sec: number): string {
-    if (sec >= 86400) {
-        // display days
-        return (Math.trunc(sec / 86400) + "d " + Math.trunc((sec % 86400) / 3600) + "h " + Math.trunc((sec % 3600) / 60) + "min " + sec % 60 + "sec");
-    } else if (sec >= 3600) {
-        // display hours
-        return (Math.trunc(sec / 3600) + "h " + Math.trunc((sec % 3600) / 60) + "min " + sec % 60 + "sec");
-    } else if (sec >= 60) {
-        // only seconds and minutes
-        return (Math.trunc(sec / 60) + "min " + sec % 60 + "sec");
-    } else {
-        // only seconds
-        return (sec + "sec");
-    }
-}
-
-export function getRealTimeString(runtime: number): string {
-    const timestamp = Date.now();
-
-    const a = new Date(timestamp - (runtime * 1000));
-    const months = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'];
-    const year = a.getFullYear();
-    const month = months[a.getMonth()];
-    const date = a.getDate();
-    const hour = a.getHours();
-    const min = "0" + a.getMinutes();
-    const sec = "0" + a.getSeconds();
-    return '[' + date + ' ' + month + ' ' + year + ' ' + hour + ':' + min.substr(-2) + ':' + sec.substr(-2) + ']';
-}

interface/src/project/types.ts

@@ -7,6 +7,8 @@ export interface SettingsState {
 }
 
 export interface GeneralInformaitonState {
+  hum: number;
+  temp: number;
   lastpumptime: number;
   lastWaterOutage: number;
   lastPumpDuration: number;
@@ -14,14 +16,4 @@ export interface GeneralInformaitonState {
   watersensor: boolean;
   pressuresensor: boolean;
   version: string;
-  pumpcycles: number;
-}
-
-export interface HeatingInformationState {
-  lastheating: number;
-  lastheatduration: number;
-  hum: number;
-  temp: number;
-  totalheattime: number;
-  heattimepercent: number;
 }

lib/framework/APSettingsService.cpp

@@ -46,7 +46,7 @@ void APSettingsService::manageAP() {
 void APSettingsService::startAP() {
   Serial.println(F("Starting software access point"));
   WiFi.softAPConfig(_state.localIP, _state.gatewayIP, _state.subnetMask);
-  WiFi.softAP(_state.ssid.c_str(), _state.password.c_str(), 1, !_state.networkVisible);
+  WiFi.softAP(_state.ssid.c_str(), _state.password.c_str());
   if (!_dnsServer) {
     IPAddress apIp = WiFi.softAPIP();
     Serial.print(F("Starting captive portal on "));

lib/framework/APSettingsService.h

@@ -28,10 +28,6 @@
 #define FACTORY_AP_PASSWORD "esp-react"
 #endif
 
-#ifndef FACTORY_AP_VISIBLE
-#define FACTORY_AP_VISIBLE true
-#endif
-
 #ifndef FACTORY_AP_LOCAL_IP
 #define FACTORY_AP_LOCAL_IP "192.168.4.1"
 #endif
@@ -57,11 +53,10 @@ class APSettings {
   IPAddress localIP;
   IPAddress gatewayIP;
   IPAddress subnetMask;
-  bool networkVisible;
 
   bool operator==(const APSettings& settings) const {
     return provisionMode == settings.provisionMode && ssid == settings.ssid && password == settings.password &&
-           localIP == settings.localIP && gatewayIP == settings.gatewayIP && subnetMask == settings.subnetMask && networkVisible == settings.networkVisible;
+           localIP == settings.localIP && gatewayIP == settings.gatewayIP && subnetMask == settings.subnetMask;
   }
 
   static void read(APSettings& settings, JsonObject& root) {
@@ -71,7 +66,6 @@ class APSettings {
     root["local_ip"] = settings.localIP.toString();
     root["gateway_ip"] = settings.gatewayIP.toString();
     root["subnet_mask"] = settings.subnetMask.toString();
-    root["network_visible"] = settings.networkVisible;
   }
 
   static StateUpdateResult update(JsonObject& root, APSettings& settings) {
@@ -87,7 +81,6 @@ class APSettings {
     }
     newSettings.ssid = root["ssid"] | FACTORY_AP_SSID;
     newSettings.password = root["password"] | FACTORY_AP_PASSWORD;
-    newSettings.networkVisible = root["network_visible"] | FACTORY_AP_VISIBLE;
 
     JsonUtils::readIP(root, "local_ip", newSettings.localIP, FACTORY_AP_LOCAL_IP);
     JsonUtils::readIP(root, "gateway_ip", newSettings.gatewayIP, FACTORY_AP_GATEWAY_IP);

src/GeneralInfoService.cpp

@@ -6,11 +6,12 @@
 #include "Pins.h"
 #include "Timer.h"
 
-GeneralInfoService::GeneralInfoService(AsyncWebServer *server) :
+GeneralInfoService::GeneralInfoService(AsyncWebServer *server, float *lasthum, float *lasttemp) :
+        hum(lasthum),
+        temp(lasttemp),
         lastPumpTime(0),
         lastWaterOutage(0),
-        lastPumpDuration(0),
+        lastPumpDuration(0) {
-        pumpCycles(0) {
     server->on(GENERALINFO_SERVICE_PATH, HTTP_GET, std::bind(&GeneralInfoService::reply, this, std::placeholders::_1));
 }
 
@@ -18,6 +19,9 @@ void GeneralInfoService::reply(AsyncWebServerRequest *request) {
     AsyncJsonResponse *response = new AsyncJsonResponse(false, MAX_FEATURES_SIZE);
     JsonObject root = response->getRoot();
 
+    root["temp"] = *temp;
+    root["hum"] = *hum;
+
     const uint32_t systime = Timer::getSystemSeconds();
 
     root["lastpumptime"] = lastPumpTime != 0 ? systime - lastPumpTime : 0;
@@ -28,8 +32,6 @@ void GeneralInfoService::reply(AsyncWebServerRequest *request) {
     root["watersensor"] = digitalRead(WasserSensorPin) ? true : false;
     root["pressuresensor"] = digitalRead(DruckSensorPin) ? true : false;
 
-    root["pumpcycles"] = pumpCycles;
-
     root["version"] = VERSION;
 
     response->setLength();
@@ -47,7 +49,3 @@ void GeneralInfoService::setlastWaterOutage(uint32_t lastWaterOutage) {
 void GeneralInfoService::setPumpDuration(uint32_t lastPumpDuration) {
     this->lastPumpDuration = lastPumpDuration;
 }
-
-void GeneralInfoService::setPumpCycles(uint32_t cycles) {
-    this->pumpCycles = cycles;
-}

src/GeneralInfoService.h

@@ -17,7 +17,7 @@
 
 class GeneralInfoService {
 public:
-    GeneralInfoService(AsyncWebServer* server);
+    GeneralInfoService(AsyncWebServer* server, float* lasthum, float* lasttemp);
 
     /**
      * sets the last time when the pump was on
@@ -37,14 +37,14 @@ public:
      */
     void setPumpDuration(uint32_t lastPumpDuration);
 
-    void setPumpCycles(uint32_t i);
-
 private:
     void reply(AsyncWebServerRequest* request);
 
+    float * hum;
+    float * temp;
+
     unsigned long lastPumpTime, lastWaterOutage, lastPumpDuration;
 
-    uint32_t pumpCycles;
 };
 
 

src/Heating.cpp

@@ -4,21 +4,18 @@
 
 #include "Heating.h"
 #include "Pins.h"
-#include "Timer.h"
 
 Heating::Heating() : mHeizungTicker(),
                      mLuefterTicker(),
                      mTurnOffTicker(),
                      msettings(nullptr),
-                     mheatingservice(nullptr),
+                     mHeatingStatus(),
-                     mHeatingStatus(false),
                      lasttemp(0),
                      lasthum(0),
                      sensor() {}
 
-void Heating::init(unsigned mode, const SettingState *settings, HeatingInfoService *heatingservice) {
+void Heating::init(unsigned mode, const SettingState *settings) {
     msettings = settings;
-    mheatingservice = heatingservice;
 
     switch (mode) {
         case TIME: {
@@ -30,13 +27,11 @@ void Heating::init(unsigned mode, const SettingState *settings, HeatingInfoServi
 
             sensor.setPin(TempSensorPin);
 
-            sensor.onData([this](float hum, float temp) {
+            sensor.onData([this, settings](float hum, float temp) {
-                schedule_function([hum, temp, this]() {
+                schedule_function([hum, temp, settings, this]() {
                     Serial.printf("Temp: %gdegC\n", temp);
                     Serial.printf("Humid: %g%%\n", hum);
 
-                    mheatingservice->setSensorData(hum, temp);
-
                     this->lasttemp = temp;
                     this->lasthum = hum;
 
@@ -48,8 +43,6 @@ void Heating::init(unsigned mode, const SettingState *settings, HeatingInfoServi
                 this->lasttemp = -1.0;
                 this->lasthum = -1.0;
 
-                mheatingservice->setSensorData(-1.0, -1.0);
-
                 // emergency turnoff of heating
                 if(mHeatingStatus){
                     digitalWrite(HeizungPin, LOW);
@@ -70,29 +63,27 @@ void Heating::init(unsigned mode, const SettingState *settings, HeatingInfoServi
     }
 }
 
+float *Heating::getLastTemp() {
+    return &lasttemp;
+}
+
+float *Heating::getLastHum() {
+    return &lasthum;
+}
+
 void Heating::handleHeatingEvents() {
     if (this->lasthum > (float) msettings->heatUp) {
-        // only turn on if turned off
-        if (mHeatingStatus == false) {
         // turn off active turnoff timers
         mLuefterTicker.detach();
         Serial.println("heating should run now!");
         // turn on heating and fan
         digitalWrite(LuefterPin, HIGH);
         digitalWrite(HeizungPin, HIGH);
-
         mHeatingStatus = true;
-            mheatingservice->setLastHeatingStarttime(Timer::getSystemSeconds());
-
-            mheatingservice->setLastHetingEndtime(0);
-        }
     } else if (this->lasthum < (float) msettings->heatLow) {
         // if humidity too low turn off heating and fan after 60secs
-        if (mHeatingStatus == true) {
         digitalWrite(HeizungPin, LOW);
         Serial.println("heating should NOT run now!");
-            // add the heat time it took to the total
-            mheatingservice->addHeatTime(Timer::getSystemSeconds() - mheatingservice->getLastHeatingStartTime());
 
         // if heating status in on set ticker to turn of fan in 60sec
         if (mHeatingStatus) {
@@ -104,11 +95,9 @@ void Heating::handleHeatingEvents() {
                 });
             });
         }
-            mheatingservice->setLastHetingEndtime(Timer::getSystemSeconds());
         mHeatingStatus = false;
     }
 }
-}
 
 void Heating::handleTimeHeater() {
     const unsigned percentOn = 20;

src/Heating.h

@@ -8,7 +8,6 @@
 #include <DHT.h>
 #include "Pins.h"
 #include "SettingsService.h"
-#include "HeatingInfoService.h"
 
 class Heating {
 public:
@@ -19,7 +18,19 @@ public:
      * @param mode select the operating mode
      * @param settings a settings object is needed for HUMIDITY mode to get percent values set by user
      */
-    void init(unsigned mode, const SettingState* settings, HeatingInfoService *heatingservice);
+    void init(unsigned mode, const SettingState* settings);
+
+    /**
+     * get the last captured humidity value
+     * @return humidity value
+     */
+    float* getLastHum();
+
+    /**
+     * get the last captured temperature value
+     * @return temperature value
+     */
+    float* getLastTemp();
 
     enum MODES {TIME, HUMIDITY};
 private:
@@ -28,7 +39,6 @@ private:
     Ticker mTurnOffTicker;
 
     const SettingState* msettings;
-    HeatingInfoService *mheatingservice;
 
     bool mHeatingStatus;
 

src/HeatingInfoService.cpp

@@ -1,58 +0,0 @@
-//
-// Created by lukas on 19.12.20.
-//
-
-#include <AsyncJson.h>
-#include "HeatingInfoService.h"
-#include "Timer.h"
-
-HeatingInfoService::HeatingInfoService(AsyncWebServer *server) :
-        hum(-1),
-        temp(-1),
-        lastheating(0),
-        lastheatend(0),
-        totalHeatTime(0) {
-    server->on(HEATINGINFO_SERVICE_PATH, HTTP_GET, std::bind(&HeatingInfoService::reply, this, std::placeholders::_1));
-}
-
-void HeatingInfoService::reply(AsyncWebServerRequest *request) {
-    AsyncJsonResponse *response = new AsyncJsonResponse(false, MAX_FEATURES_SIZE);
-    JsonObject root = response->getRoot();
-
-    root["temp"] = temp;
-    root["hum"] = hum;
-
-    const uint32_t systime = Timer::getSystemSeconds();
-
-    root["lastheating"] = lastheating != 0 ? systime - lastheating : 0;
-    // if lastheating == 0 => there was no cycle upon now
-    // if lastheatend == 0 => heating is currently active
-    root["lastheatduration"] = lastheating == 0 ? 0 : lastheatend == 0 ? -1 : lastheatend - lastheating;
-
-    root["totalheattime"] = this->totalHeatTime;
-    root["heattimepercent"] = (float)this->totalHeatTime / (float)Timer::getSystemSeconds();
-
-    response->setLength();
-    request->send(response);
-}
-
-void HeatingInfoService::setSensorData(float hum, float temp) {
-    this->hum = hum;
-    this->temp = temp;
-}
-
-void HeatingInfoService::setLastHeatingStarttime(unsigned long time) {
-    this->lastheating = time;
-}
-
-void HeatingInfoService::setLastHetingEndtime(unsigned long time) {
-    this->lastheatend = time;
-}
-
-uint32_t HeatingInfoService::getLastHeatingStartTime() {
-    return this->lastheating;
-}
-
-void HeatingInfoService::addHeatTime(uint32_t time) {
-    totalHeatTime += time;
-}

src/HeatingInfoService.h

@@ -1,44 +0,0 @@
-//
-// Created by lukas on 19.12.20.
-//
-
-#ifndef PUMPENSTEUERUNG_HEATINGINFOSERVICE_H
-#define PUMPENSTEUERUNG_HEATINGINFOSERVICE_H
-
-#include <ESPAsyncWebServer.h>
-
-#define MAX_FEATURES_SIZE 256
-#define HEATINGINFO_SERVICE_PATH "/rest/heatinginfo" // set the api backend path
-
-
-class HeatingInfoService {
-public:
-    HeatingInfoService(AsyncWebServer* server);
-
-    void setSensorData(float hum, float temp);
-
-    void setLastHeatingStarttime(unsigned long time);
-    uint32_t getLastHeatingStartTime();
-
-    void setLastHetingEndtime(unsigned long time);
-
-    /**
-     * add time how long the heater heated
-     * @param time time in seconds
-     */
-    void addHeatTime(uint32_t time);
-
-private:
-    void reply(AsyncWebServerRequest* request);
-
-    float hum;
-    float temp;
-
-    unsigned long lastheating;
-    unsigned long lastheatend;
-
-    uint32_t totalHeatTime;
-};
-
-
-#endif //PUMPENSTEUERUNG_HEATINGINFOSERVICE_H

src/Pins.h

@@ -16,6 +16,6 @@
 #define TempSensorPin  D4
 
 // version info
-#define VERSION "v1.2.4-Alpha2"
+#define VERSION "v1.2.2"
 
 #endif //PUMPENSTEUERUNG_PINS_H

src/main.cpp

@@ -6,7 +6,6 @@
 #include "GeneralInfoService.h"
 #include "SettingsService.h"
 #include "Timer.h"
-#include "HeatingInfoService.h"
 
 bool allow;
 bool error = false;
@@ -15,19 +14,17 @@ bool error = false;
 Ticker status;
 
 //pumpendauer maximum ticker
-Ticker pumpendauer, wasserSensorDoubleCheck;
+Ticker pumpendauer;
 
 //WifiManager mang;
 Heating mHeat;
 
 uint32_t turnontime = 0;
-uint32_t pumpcycles = 0;
 
 AsyncWebServer server(80);
 ESP8266React esp8266React(&server);
 
-GeneralInfoService generalinfo = GeneralInfoService(&server);
+GeneralInfoService generalinfo = GeneralInfoService(&server, mHeat.getLastHum(), mHeat.getLastTemp());
-HeatingInfoService heatinginfo = HeatingInfoService(&server);
 SettingsService settingsservice = SettingsService(&server, esp8266React.getSecurityManager());
 
 void pumpeSchalten(bool on) {
@@ -42,13 +39,9 @@ void pumpeSchalten(bool on) {
 
     if (allow && !error) {
         if (on) {
-            pumpcycles++;
-            generalinfo.setPumpCycles(pumpcycles);
-
             pumpendauer.once((float)settingsservice.getSettings()->maxpumpduration + 1, []() {
                 //erlaube keine einschaltung von mehr als 60 sek
-                if (Timer::getSystemSeconds() - turnontime >=
+                if (Timer::getSystemSeconds() - turnontime >= (unsigned)settingsservice.getSettings()->maxpumpduration && turnontime != 0) {
-                    (unsigned) settingsservice.getSettings()->maxpumpduration && turnontime != 0) {
                     //error zu lange
                     Serial.println("\n\npumpe lief mehr als 10 Minuten durchgaengig");
                     pumpeSchalten(false);
@@ -65,8 +58,7 @@ void pumpeSchalten(bool on) {
         digitalWrite(SchuetzPin, on);
         Serial.println("[Erfolg] pumpe wird geschalten");
     } else {
-        Serial.println(
+        Serial.println("[FEHLGESCHLAGEN] Schalten des Schütz gesperrt durch Timeout oder Fehler-- sofortiges ausschalten der pumpe\n");
-                "[FEHLGESCHLAGEN] Schalten des Schütz gesperrt durch Timeout oder Fehler-- sofortiges ausschalten der pumpe\n");
         turnontime = -1;
         digitalWrite(SchuetzPin, LOW);
     }
@@ -94,9 +86,6 @@ ICACHE_RAM_ATTR void DruckschalterInt() {
 int wateroutagewaitduration;
 
 void WasserSensorCheck() {
-    if (digitalRead(WasserSensorPin) == LOW) {
-        // check if water sensor is also low after 500ms and lock it then
-        wasserSensorDoubleCheck.once_ms(500, []() {
     if (digitalRead(WasserSensorPin) == LOW) {
         Serial.println("Wasser Sensor AUS");
         //kein Wasser dh timer auf 10min stellen
@@ -113,8 +102,6 @@ void WasserSensorCheck() {
         status.detach();
 
         wateroutagewaitduration = settingsservice.getSettings()->waterOutageWaitDuration;
-
-                status.detach();
         status.attach(5, []() {
             wateroutagewaitduration -= 5;
             Serial.print("noch ");
@@ -122,7 +109,6 @@ void WasserSensorCheck() {
             Serial.println(" Sekunden verbleibend");
 
             if (wateroutagewaitduration <= 0) {
-                        status.detach();
                 if (digitalRead(WasserSensorPin)) {
                     allow = true;
                     Serial.println("Einschalten der Pumpe wieder erlaubt.");
@@ -133,8 +119,7 @@ void WasserSensorCheck() {
                     Serial.print("wassersensor immer noch kein Wasser --> verlaengern um 120min\n\n");
                     WasserSensorCheck();
                 }
-                    }
+                status.detach();
-                });
             }
         });
     } else {
@@ -195,7 +180,7 @@ void setup() {
 
     // initialize heating control
     Serial.println("initializing heating service");
-    mHeat.init(Heating::HUMIDITY, settingsservice.getSettings(), &heatinginfo);
+    mHeat.init(Heating::HUMIDITY, settingsservice.getSettings());
 
     Serial.println("startup sequence complete!\n");
 }