code cleanup

deleted deadcode

src/java/com/wasteinformationserver/db/Database.java

@@ -1,25 +0,0 @@
-package com.wasteinformationserver.db;
-
-import java.sql.Connection;
-import java.sql.SQLException;
-
-abstract class Database {
-
-    protected String user;
-    protected String password;
-
-    protected String host;
-    protected int port;
-
-    protected String dbName;
-
-    public Database(String user, String password, String host, int port, String dbName) {
-        this.user = user;
-        this.password = password;
-        this.host = host;
-        this.port = port;
-        this.dbName = dbName;
-    }
-
-    public abstract Connection getConnection() throws SQLException;
-}

src/java/com/wasteinformationserver/db/JDBC.java

@@ -3,10 +3,7 @@ package com.wasteinformationserver.db;
 import com.wasteinformationserver.basicutils.Log;
 
 import java.io.IOException;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
+import java.sql.*;
 
 /**
  * basic connection class to a Database
@@ -25,6 +22,21 @@ public class JDBC {
     private static String ipc;
     private static int portc;
 
+    private JDBC(String username, String password, String dbname, String ip, int port) throws IOException {
+        logintodb(username, password, dbname, ip, port);
+    }
+
+    /**
+     * instance of JDBC driver
+     */
+    static {
+        try {
+            Class.forName("com.mysql.cj.jdbc.Driver").getDeclaredConstructor().newInstance();
+        } catch (Exception e) {
+            e.printStackTrace();
+        }
+    }
+
     /**
      * initialize database values
      * suggested on startup
@@ -45,10 +57,6 @@ public class JDBC {
         JDBC = new JDBC(username, password, dbname, ip, port);
     }
 
-    private JDBC(String username, String password, String dbname, String ip, int port) throws IOException {
-        logintodb(username, password, dbname, ip, port);
-    }
-
     /**
      * get instance of db object
      * logindata has to be set before!
@@ -67,22 +75,28 @@ public class JDBC {
         return JDBC;
     }
 
+    /**
+     * initial login to db -- should be called only one time or for reconnect
+     *
+     * @param username username
+     * @param password password
+     * @param dbname   Database name
+     * @param ip       Host or ip address
+     * @param port     Server port
+     * @throws IOException thrown if no connection to db is possible.
+     */
     private static void logintodb(String username, String password, String dbname, String ip, int port) throws IOException {
-        Database db = new MySQLConnector(
-                username,
-                password,
-                ip,
-                port,
-                dbname);
-
         try {
-            conn = db.getConnection();
+            DriverManager.setLoginTimeout(1);
+            conn = DriverManager.getConnection(
+                    "jdbc:mysql://" + ip + ":" + port + "/" + dbname + "?useSSL=false&serverTimezone=CET",
+                    username,
+                    password);
             loggedin = true;
         } catch (SQLException e) {
             throw new IOException("No connection to database");
             // todo reconnect every 5mins or something
         }
-
     }
 
     /**
@@ -114,6 +128,11 @@ public class JDBC {
         return stmt.executeUpdate();
     }
 
+    /**
+     * check if connection is still established
+     *
+     * @return connection state
+     */
     public boolean isConnected() {
         return loggedin;
     }

src/java/com/wasteinformationserver/db/MySQLConnector.java

@@ -1,29 +0,0 @@
-package com.wasteinformationserver.db;
-
-import java.sql.Connection;
-import java.sql.DriverManager;
-import java.sql.SQLException;
-
-class MySQLConnector extends Database {
-
-    static {
-        try {
-            Class.forName("com.mysql.cj.jdbc.Driver").getDeclaredConstructor().newInstance();
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
-    }
-
-    public MySQLConnector(String user, String password, String host, int port, String dbName) {
-        super(user, password, host, port, dbName);
-    }
-
-    public Connection getConnection() throws SQLException {
-        DriverManager.setLoginTimeout(1);
-        return DriverManager.getConnection(
-                "jdbc:mysql://" + host + ":" + port + "/" + dbName + "?useSSL=false&serverTimezone=CET",
-                user,
-                password);
-    }
-
-}